Gitlab runner scaler #6412
Draft
Gitlab runner scaler #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fira Curie <[email protected]>
… "waiting for resource" status Signed-off-by: Fira Curie <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Fira Curie <[email protected]>
* chore: Prepare v2.15.1 Signed-off-by: Jorge Turrado <[email protected]> * fix changelog Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>
* chore: Enable Az Pipeline e2e Signed-off-by: Jorge Turrado <[email protected]> * update manifests Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
* chore: Improve azure e2e coverage Signed-off-by: Jorge Turrado <[email protected]> * add missing vars Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: Fira Curie <[email protected]>
…dacore#6072) * Update Signed-off-by: SpiritZhou <[email protected]> * Update ChangeLog Signed-off-by: SpiritZhou <[email protected]> * Update Signed-off-by: SpiritZhou <[email protected]> --------- Signed-off-by: SpiritZhou <[email protected]> Signed-off-by: Fira Curie <[email protected]>
) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: Fira Curie <[email protected]>
* add errorWhenMetricValueEmpty Signed-off-by: Rob Pickerill <[email protected]> * fix golangci-lint Signed-off-by: Rob Pickerill <[email protected]> * improve error message for empty results Signed-off-by: Rob Pickerill <[email protected]> * add error when empty metric values to changelog Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * use getParameterFromConfigV2 to read config for errorWhenNullValues Signed-off-by: Rob Pickerill <[email protected]> * add e2e for error state for cw, and improve e2e for min values for cw Signed-off-by: Rob Pickerill <[email protected]> * remove erroneous print statement Signed-off-by: Rob Pickerill <[email protected]> * remove unused vars Signed-off-by: Rob Pickerill <[email protected]> * rename errorWhenMetricValuesEmpty -> ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * move towards shared package for e2e aws Signed-off-by: Rob Pickerill <[email protected]> * minMetricValue optionality based on ignoreNullValues Signed-off-by: Rob Pickerill <[email protected]> * fail fast Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_ignore_null_values_false/aws_cloudwatch_ignore_null_values_false_test.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * Apply suggestions from code review Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fail fast Signed-off-by: Rob Pickerill <[email protected]> * fix broken new line Signed-off-by: Rob Pickerill <[email protected]> * fix broken new lines Signed-off-by: Rob Pickerill <[email protected]> * assert no scaling changes in e2e, and set false for required in minMetricValue Signed-off-by: robpickerill <[email protected]> * fix ci checks Signed-off-by: robpickerill <[email protected]> * Update tests/scalers/aws/aws_cloudwatch_min_metric_value/aws_cloudwatch_min_metric_value_test.go fix invalid check Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * fix merge conflicts Signed-off-by: robpickerill <[email protected]> * fix e2e package names Signed-off-by: robpickerill <[email protected]> --------- Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: robpickerill <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>
* add a static connection name Signed-off-by: robpickerill <[email protected]> * Update pkg/scalers/rabbitmq_scaler.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * add improvement to changelog Signed-off-by: robpickerill <[email protected]> * add namepace and so name to conn name Signed-off-by: robpickerill <[email protected]> * Update comment Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: robpickerill <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
…b scaler; apply code review suggestions Signed-off-by: Fira Curie <[email protected]>
… gitlab-runner-scaler
|
related to #6087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #5616